Closed brenner-company closed 1 year ago
Example of the loading state functionality, currently implemented within Kaleidos:
👍 for most of the bullets, but I'm not sure I'm a fan of adding a loading state here. That seems like a very niche use-case since usually switching the toggle doesn't start an async action.
I think it might be better to support something like this instead?
<AuToggleSwitch>
{{#if this.isRunning}}
<AuLoader />
{{else}}
Te handtekenen
{{/if}}
</AuToggleSwitch>
(Pseudocode, but you get the idea)
If the pattern also becomes more common in other Appuniversum apps, we can then add it to the component itself.
👍 for most of the bullets, but I'm not sure I'm a fan of adding a loading state here. That seems like a very niche use-case since usually switching the toggle doesn't start an async action.
I think it might be better to support something like this instead?
<AuToggleSwitch> {{#if this.isRunning}} <AuLoader /> {{else}} Te handtekenen {{/if}} </AuToggleSwitch>
(Pseudocode, but you get the idea)
If the pattern also becomes more common in other Appuniversum apps, we can then add it to the component itself.
That is totally ok for us 👍 We thought the 'issue' was already more common within other apps.
I'll start on a PR for the remaining items today or tomorrow.
Within Kaleidos we could use the following functionality for the
AuToggleSwitch
component:AuControlCheckbox
andAuControlRadio
).AuButton
).Together with some general adjustments:
gap
(already within a few other components).Is this something that can be added to the component? If yes, I can surely help with that.