search

appuniversum / ember-appuniversum

Ember addon wrapping the appuniversum components.
https://appuniversum.github.io/ember-appuniversum
MIT License
14 stars 11 forks source link

Addition of clear action within toaster service #414

Closed brenner-company closed 1 year ago

brenner-company commented 1 year ago

The addition of a clear function within the toaster service.

More information can be found inside the complementary FR: https://github.com/appuniversum/ember-appuniversum/issues/413.

Windvis commented 1 year ago

Sounds good 👍. Maybe also add the code snippet to the Storybook? I don't think we documented that the display methods return "toast" objects yet.

brenner-company commented 1 year ago

Sounds good! I'll finalize this PR when I get back.

Windvis commented 1 year ago

I added some tweaks in #418 that targets this PR. Should be good to go I think (unless you have strong opinions about the method rename 😄).

brenner-company commented 1 year ago

I added some tweaks in #418 that targets this PR.

Thanks for the help!

Should be good to go I think (unless you have strong opinions about the method rename 😄).

Nono, I just used clear because it was the name we used in Kaleidos to clear the toasts. Sounds good!