search

appuniversum / ember-appuniversum

Ember addon wrapping the appuniversum components.
https://appuniversum.github.io/ember-appuniversum
MIT License
14 stars 11 forks source link

.gjs conversion #440

Closed Windvis closed 11 months ago

Windvis commented 11 months ago

This sets up ember-template-imports and converts most components to .gjs files.

Github doesn't have syntax highlighing support for .gjs yet since it requires a certain amount of files in (public?) repos. With this change we're helping a bit 😄.

This is an internal change, consumers shouldn't notice anything different and if they do it's most likely a bug.

Windvis commented 11 months ago

The linting faillure is because of node 14.. We should bump it to 18 for the dev / CI setup and fix issues for node 14 when we run into them (until the next major, which should be released in the near future).

Edit: Resolved by #441

Windvis commented 11 months ago

It seems there is an issue with accidental leading and trailing whitespace due to the conversion. I'm trying to figure out what the best way to deal with this is.

Edit: I went with the {{~!~}} workaround but it logs messages when building the app, so not perfect either.