search

appuniversum / ember-appuniversum

Ember addon wrapping the appuniversum components.
https://appuniversum.github.io/ember-appuniversum
MIT License
14 stars 11 forks source link

`<AuLoader>` alignment #472

Closed Windvis closed 6 months ago

Windvis commented 6 months ago

In #464 we added a new variant of the AuLoader component that matches the setup that is documented by Webuniversum. All the examples in the documentation used a centered loader, so I centered the Appuniversum version as well.

In practice, however, I noticed that the centered loader looks out of place for some use-cases. Looking at the Webuniversum documentation in more detail it seems that the centering is not part of the vl-loader styles, but they use a vl-u-align-center utility class instead.

It's not very clear if Webuniversum also uses non-centered variations of the loader, but I feel that we should either remove the default centering (so they can add a class as well), or add an option to disable it, but still center by default.

If we do remove the default I would consider it a bugfix instead of a breaking change, since I implemented it wrong. The opt-out isn't breaking so there is no problem there.

Windvis commented 6 months ago

Discussed this with Saška and we decided to keep centering the loader by default, but add an option to opt-out of that behavior where needed.