search

appuniversum / ember-appuniversum

Ember addon wrapping the appuniversum components.
https://appuniversum.github.io/ember-appuniversum
MIT License
14 stars 11 forks source link

Resolve some issues with `babel-plugin-ember-template-compilation` v2.2.2+ #492

Closed Windvis closed 3 months ago

Windvis commented 4 months ago

The v2.2.2 release breaks our ember-template-imports v3 based setup.

We need to update to v4 to fix those and also fix the scope issues we accidentally depended on.

Draft since it seems to break the storybook setup. We probably need to update that first? Not sure what changed or what the issue was, but storybook seems to work now.

Fixes #491

TODO:

Windvis commented 3 months ago

I tested this out in an v4.12 app with ember-cli-babel v7 and ember-template-imports throws an exception because it expects ember-cli-babel v8. If that isn't a bug (we're not using template-imports in the app itself) I don't think we can release this as a bugfix.. And we weren't planning on releasing v4 yet either..

Edit: I think it's a bug in ember-template-imports which should be fixed by https://github.com/ember-template-imports/ember-template-imports/pull/236

Discord discussion: https://discord.com/channels/480462759797063690/1239836417950220359

Windvis commented 3 months ago

(Canary will fail until the fix is merged in ember-source, but we'll just ignore that since it will resolve itself eventually)