appuniversum / ember-appuniversum

Ember addon wrapping the appuniversum components.
https://appuniversum.github.io/ember-appuniversum
MIT License
14 stars 11 forks source link

Deprecate the default loading message in the `AuButton` component #495

Closed Windvis closed 1 month ago

Windvis commented 1 month ago

The AuButton component has an @loading argument which makes it display a loading animation and text. If the @loadingMessage argument isn't provided it defaults to "Aan het laden". This sounds fine, but I've seen it happen that this message isn't adjusted and that the default message doesn't really make sense in the context where the button is used.

It was a strange default message for button in the first place since buttons aren't usually used to load anything.

I think we should just deprecate the default message and force users to set @loadingMessage when @loading is used.