appuniversum / ember-appuniversum

Ember addon wrapping the appuniversum components.
https://appuniversum.github.io/ember-appuniversum
MIT License
14 stars 11 forks source link

[AuButton] deprecate the default loading message #497

Closed Windvis closed 1 month ago

Windvis commented 1 month ago

The default loading message is a footgun. Many projects forget to properly set this which means the default is used, even though it's not a good fit for the context. This is only made worse by the fact that the AuButton component didn't visually display the loading message originally, so a lot of older code doesn't set this message explicitly.

By requiring an explicit loading message this should no longer be an issue.

Migration guide

Simply add a @loadingMessage argument if you are using the @loading argument on a <AuButton> component. To get the exact same result as the current behavior you can use the following code:

- <AuButton @loading={{true}}>Some action</AuButton>
+ <AuButton @loading={{true}} @loadingMessage="Aan het laden">Some action</AuButton>

There are few places where the default loading message makes sense in buttons though, so we recommend evaluating all places where the loading state of the button is used and using a good loading message for the context it is used in.

Closes #495