appuniversum / ember-appuniversum

Ember addon wrapping the appuniversum components.
https://appuniversum.github.io/ember-appuniversum
MIT License
14 stars 11 forks source link

Add types for the data-table components #498

Closed Windvis closed 1 week ago

Windvis commented 4 months ago

This copies over the ember-data-table .js code so we no longer need the addon itself. We were already overriding all the templates. This will make things easier to maintain and improve in the future.

Linting errors are silenced with inline ignore comments. They will be fixed once we convert the code to .gts.

This is a good base to start the .gts conversion from.

TODO:

Out of scope:

Windvis commented 3 months ago

Hmmm, I'm not sure if this is possible in a backwards compatible way. Some ember-data-table components mutate arguments, which is no longer possible with Glimmer components. Consumers would have to pass in an action, which isn't a huge issue, but it requires a code change.

It might be possible to make this an opt-in breaking change by using the embroider macros, and only expose the new implementation if the consuming app opted in.

Maybe we should settle on providing types for the classic ember components instead for now.

Windvis commented 1 week ago

Closing since it's essentially the same as #525. I'll reopen it once I start on the actual type work.