appuniversum / ember-appuniversum

Ember addon wrapping the appuniversum components.
https://appuniversum.github.io/ember-appuniversum
MIT License
14 stars 11 forks source link

Fix the order of the "spacing" utilities #501

Closed Windvis closed 3 months ago

Windvis commented 3 months ago

The responsive versions of the spacing utilities were generated before the standard ones. This causes issues if you use a "mobile first" pattern, where you start out with the non-responsive classes and add overrides with the responsive versions if needed. Since the responsive version was defined before the regular one, the regular one always wins. By changing the order it now works as expected.

To clarify with a code snippet:

<div class="au-u-margin-top-tiny au-u-margin-top-large@medium"></div>

Before this change the margin would always be "tiny" even on medium breakpoints. After this change it will properly switch to the large margin when the medium breakpoint is active.