appveyor / ci

AppVeyor community support repository
https://www.appveyor.com
344 stars 64 forks source link

Azure Service Fabric deployment #1566

Open FeodorFitsner opened 7 years ago

PTC-JoshuaMatthews commented 7 years ago

I am having an issue where I cannot deploy from appveyor since the last service fabric sdk update. Is this related?

FeodorFitsner commented 7 years ago

What version of Azure SDK do you depend on?

FeodorFitsner commented 7 years ago

Check if that SO article can help with your issue.

PTC-JoshuaMatthews commented 7 years ago

SDK is 2.6.210

The appveyor version is SDK 2.5.216

It has been working previously, but it seems they have added something in this build of 2.6 that isn't compatible with the 2.5 sdk.

PTC-JoshuaMatthews commented 7 years ago

The SO article is not relevant since I do not connect to a cluster manually

PTC-JoshuaMatthews commented 7 years ago

Also the user LoekD from that SO post is the same guy who just helped me come to the conclusion that the build server needs the latest version of service fabric sdk to publish.

FeodorFitsner commented 7 years ago

OK, so we need to update Azure Fabric SDK then. Added new issue for that: https://github.com/appveyor/ci/issues/1591

PTC-JoshuaMatthews commented 7 years ago

LOL didn't realize you were manning appveyor support! Sorry for hitting you from two direction! Any way I can do it manually until the update? Also I'm not 100% sure that is even the issue so would be nice to test somehow.

IlyaFinkelshteyn commented 7 years ago

Actually from three directions, because we look at SO AppVeyor-tagged questions too :) We could not figure out a good script to install it silently if older version is already on VM. What you can do (and we will appreciate that), is to set blocking RDP at init stage, install it manually and then continue the build (by deleting blocking file).

PTC-JoshuaMatthews commented 7 years ago

Is there an update on this? I haven't had time to validate, but still not working on my end.

FeodorFitsner commented 7 years ago

@PTC-JoshuaMatthews how do you currently do the deployment of Service Fabric app? Is it possible to do it from script/command line?

PTC-JoshuaMatthews commented 7 years ago

@FeodorFitsner Currently from powershell script on appveyor. Can do from local as well if need be. Why do you ask?

FeodorFitsner commented 7 years ago

I'm trying to understand the use case and have a proof-of-concept for implementation. So, the goal here is deploy to SF from Environments, right?

PTC-JoshuaMatthews commented 7 years ago

yes from a vs2015 build image.

PTC-JoshuaMatthews commented 7 years ago

@FeodorFitsner Any update on this?

https://stackoverflow.com/questions/44396739/service-fabric-1-5-deployments-failing?noredirect=1#comment75798341_44396739

FeodorFitsner commented 7 years ago

Current implementation of Environments does not allow running untrusted code (executables, PS scripts, etc.), so SF deployment provide would become possible in planned "Environments V2" made on Docker.

For now you can look at https://www.appveyor.com/blog/2015/11/04/deployment-projects/

PTC-JoshuaMatthews commented 7 years ago

@FeodorFitsner Can you expand on that some? Everything i am doing has been supported appveyor up until this version of the sdk. I have been using this feature since I signed up. All of the sudden an sdk update comes along and now it is impossible? That doesn't make sense. The Service fabric deploy has always been dependent on the SDK being installed on the build image as you can see in the stack overflow post I attached. There must already be a version of the sdk installed since my deploys were working. All that needs to happen is that sdk be updated to latest version. Is this really not possible?

FeodorFitsner commented 7 years ago

Service Fabric SDK has been always available on build workers. Currently, the latest one is 2.6: https://github.com/appveyor/ci/issues/1591 and it's available on both VS 2015 and VS 2017 images. Did SDK 2.6 break your deployment - could you please clarify? I was assuming you are asking about ability to deploy SF package from Environments?

PTC-JoshuaMatthews commented 7 years ago

Okay I didn't realize 1591 has been closed out. My deploy issue remains. Not sure why, it works locally with same SDK version and same powershell deployment script and package.

FeodorFitsner commented 7 years ago

Have you tried logging in to build worker via RDP and try deploying from command line (or see if there is anything missing on build server)?

PTC-JoshuaMatthews commented 7 years ago

i will do that now that I see that the sdk didn't fix it.

PTC-JoshuaMatthews commented 6 years ago

@FeodorFitsner Hey I figured out the issue. Turns out in the latest Service Fabric sdk you now are required to call Connect-ServiceFabricCluster before calling the deploy script. In the past this was only required if the cluster was secured and needed auth credentials. Now that I am calling it everything is working again. Thanks for the help!

FeodorFitsner commented 6 years ago

Cool, thanks for the update!