GitLab merge request builds triggered for all MR updates (including description / label changes, etc.) #2895

Open Ede123 opened 5 years ago

Every "update" action of a GitLab merge request seems to trigger a new AppVeyor build, including all non-code changes like description updates, changes in labelling, etc.

New builds should only be triggered if new commits where actually pushed to a merge request.

Examples

Description update:

https://ci.appveyor.com/project/inkscape/inkscape/builds/23306535

Merge request hook data

``` { "object_kind": "merge_request", "event_type": "merge_request", "user": { "name": "Patrick Storz", "username": "ede123", "avatar_url": "https://assets.gitlab-static.net/uploads/-/system/user/avatar/945074/avatar.png" }, "project": { "id": 3472737, "name": "inkscape", "description": "Inkscape vector illustrator", "web_url": "https://gitlab.com/inkscape/inkscape", "avatar_url": "https://assets.gitlab-static.net/uploads/-/system/project/avatar/3472737/inkscape.png", "git_ssh_url": "git@gitlab.com:inkscape/inkscape.git", "git_http_url": "https://gitlab.com/inkscape/inkscape.git", "namespace": "Inkscape", "visibility_level": 20, "path_with_namespace": "inkscape/inkscape", "default_branch": "master", "ci_config_path": null, "homepage": "https://gitlab.com/inkscape/inkscape", "url": "git@gitlab.com:inkscape/inkscape.git", "ssh_url": "git@gitlab.com:inkscape/inkscape.git", "http_url": "https://gitlab.com/inkscape/inkscape.git" }, "object_attributes": { "assignee_id": 405008, "author_id": 402171, "created_at": "2019-03-19 21:41:02 UTC", "description": "Improvements done:\r\n* Now expanders retain his open/close status anyone operation you do.\r\n* Expanders become open on add\r\n* Now we can use complex nested classes, it works in browsers and maybe inside Inkscape and can have (in the future styling) but this not have items inside and have a different icon (lock)\r\n* Now we can select multiple selectors if the user select it in the canvas\r\n* You only can delete a selector if is empty (Remove a CSS Selector button)\r\n", "head_pipeline_id": 53232179, "id": 26027619, "iid": 593, "last_edited_at": "2019-03-23 16:22:14 UTC", "last_edited_by_id": 945074, "merge_commit_sha": null, "merge_error": null, "merge_params": { "force_remove_source_branch": "0" }, "merge_status": "can_be_merged", "merge_user_id": null, "merge_when_pipeline_succeeds": false, "milestone_id": null, "source_branch": "ImproveStyleAndSelectorDialog", "source_project_id": 3472737, "state": "opened", "target_branch": "master", "target_project_id": 3472737, "time_estimate": 0, "title": "ImproveSelectorDialog", "updated_at": "2019-03-23 16:22:14 UTC", "updated_by_id": 945074, "url": "https://gitlab.com/inkscape/inkscape/merge_requests/593", "source": { "id": 3472737, "name": "inkscape", "description": "Inkscape vector illustrator", "web_url": "https://gitlab.com/inkscape/inkscape", "avatar_url": "https://assets.gitlab-static.net/uploads/-/system/project/avatar/3472737/inkscape.png", "git_ssh_url": "git@gitlab.com:inkscape/inkscape.git", "git_http_url": "https://gitlab.com/inkscape/inkscape.git", "namespace": "Inkscape", "visibility_level": 20, "path_with_namespace": "inkscape/inkscape", "default_branch": "master", "ci_config_path": null, "homepage": "https://gitlab.com/inkscape/inkscape", "url": "git@gitlab.com:inkscape/inkscape.git", "ssh_url": "git@gitlab.com:inkscape/inkscape.git", "http_url": "https://gitlab.com/inkscape/inkscape.git" }, "target": { "id": 3472737, "name": "inkscape", "description": "Inkscape vector illustrator", "web_url": "https://gitlab.com/inkscape/inkscape", "avatar_url": "https://assets.gitlab-static.net/uploads/-/system/project/avatar/3472737/inkscape.png", "git_ssh_url": "git@gitlab.com:inkscape/inkscape.git", "git_http_url": "https://gitlab.com/inkscape/inkscape.git", "namespace": "Inkscape", "visibility_level": 20, "path_with_namespace": "inkscape/inkscape", "default_branch": "master", "ci_config_path": null, "homepage": "https://gitlab.com/inkscape/inkscape", "url": "git@gitlab.com:inkscape/inkscape.git", "ssh_url": "git@gitlab.com:inkscape/inkscape.git", "http_url": "https://gitlab.com/inkscape/inkscape.git" }, "last_commit": { "id": "73a0b7969ddcff550af4840e13bc07ed23144ab7", "message": "Add some handling fixes to selector classes\n", "timestamp": "2019-03-23T01:20:15Z", "url": "https://gitlab.com/inkscape/inkscape/commit/73a0b7969ddcff550af4840e13bc07ed23144ab7", "author": { "name": "Jabier Arraiza", "email": "jabier.arraiza@marker.es" } }, "work_in_progress": false, "total_time_spent": 0, "human_total_time_spent": null, "human_time_estimate": null, "action": "update" }, "labels": [ ], "changes": { "description": { "previous": "Improvements done:\r\n* Now expanders retain his open/close status anyone operation you do.\r\n* Expanders become open on add\r\n* Now we can use complex nested classes, it works in browsers and maybe inside Inkscape and can have (in the future styling) but this not have items inside and have a different icon (lock)\r\n* Now we can select multiple selectors if the user select it in the canvas\r\n* You only can delete a selector if is empty (Remove a CSS Selector button)", "current": "Improvements done:\r\n* Now expanders retain his open/close status anyone operation you do.\r\n* Expanders become open on add\r\n* Now we can use complex nested classes, it works in browsers and maybe inside Inkscape and can have (in the future styling) but this not have items inside and have a different icon (lock)\r\n* Now we can select multiple selectors if the user select it in the canvas\r\n* You only can delete a selector if is empty (Remove a CSS Selector button)\r\n" }, "last_edited_at": { "previous": "2019-03-23 13:01:04 UTC", "current": "2019-03-23 16:22:14 UTC" }, "last_edited_by_id": { "previous": 402171, "current": 945074 }, "updated_at": { "previous": "2019-03-23 13:01:04 UTC", "current": "2019-03-23 16:22:14 UTC" }, "updated_by_id": { "previous": 402171, "current": 945074 } }, "repository": { "name": "inkscape", "url": "git@gitlab.com:inkscape/inkscape.git", "description": "Inkscape vector illustrator", "homepage": "https://gitlab.com/inkscape/inkscape" }, "assignee": { "name": "Tavmjong Bah", "username": "Tavmjong", "avatar_url": "https://secure.gravatar.com/avatar/faf7c5b7f2c3eb1a151d0b4f73345397?s=80&d=identicon" } } ```

Addition of a label:

https://ci.appveyor.com/project/inkscape/inkscape/builds/23306611

Merge request hook data

``` { "object_kind": "merge_request", "event_type": "merge_request", "user": { "name": "Patrick Storz", "username": "ede123", "avatar_url": "https://assets.gitlab-static.net/uploads/-/system/user/avatar/945074/avatar.png" }, "project": { "id": 3472737, "name": "inkscape", "description": "Inkscape vector illustrator", "web_url": "https://gitlab.com/inkscape/inkscape", "avatar_url": "https://assets.gitlab-static.net/uploads/-/system/project/avatar/3472737/inkscape.png", "git_ssh_url": "git@gitlab.com:inkscape/inkscape.git", "git_http_url": "https://gitlab.com/inkscape/inkscape.git", "namespace": "Inkscape", "visibility_level": 20, "path_with_namespace": "inkscape/inkscape", "default_branch": "master", "ci_config_path": null, "homepage": "https://gitlab.com/inkscape/inkscape", "url": "git@gitlab.com:inkscape/inkscape.git", "ssh_url": "git@gitlab.com:inkscape/inkscape.git", "http_url": "https://gitlab.com/inkscape/inkscape.git" }, "object_attributes": { "assignee_id": 405008, "author_id": 402171, "created_at": "2019-03-19 21:41:02 UTC", "description": "Improvements done:\r\n* Now expanders retain his open/close status anyone operation you do.\r\n* Expanders become open on add\r\n* Now we can use complex nested classes, it works in browsers and maybe inside Inkscape and can have (in the future styling) but this not have items inside and have a different icon (lock)\r\n* Now we can select multiple selectors if the user select it in the canvas\r\n* You only can delete a selector if is empty (Remove a CSS Selector button)\r\n", "head_pipeline_id": 53232179, "id": 26027619, "iid": 593, "last_edited_at": "2019-03-23 16:22:14 UTC", "last_edited_by_id": 945074, "merge_commit_sha": null, "merge_error": null, "merge_params": { "force_remove_source_branch": "0" }, "merge_status": "can_be_merged", "merge_user_id": null, "merge_when_pipeline_succeeds": false, "milestone_id": null, "source_branch": "ImproveStyleAndSelectorDialog", "source_project_id": 3472737, "state": "opened", "target_branch": "master", "target_project_id": 3472737, "time_estimate": 0, "title": "ImproveSelectorDialog", "updated_at": "2019-03-23 16:28:53 UTC", "updated_by_id": 945074, "url": "https://gitlab.com/inkscape/inkscape/merge_requests/593", "source": { "id": 3472737, "name": "inkscape", "description": "Inkscape vector illustrator", "web_url": "https://gitlab.com/inkscape/inkscape", "avatar_url": "https://assets.gitlab-static.net/uploads/-/system/project/avatar/3472737/inkscape.png", "git_ssh_url": "git@gitlab.com:inkscape/inkscape.git", "git_http_url": "https://gitlab.com/inkscape/inkscape.git", "namespace": "Inkscape", "visibility_level": 20, "path_with_namespace": "inkscape/inkscape", "default_branch": "master", "ci_config_path": null, "homepage": "https://gitlab.com/inkscape/inkscape", "url": "git@gitlab.com:inkscape/inkscape.git", "ssh_url": "git@gitlab.com:inkscape/inkscape.git", "http_url": "https://gitlab.com/inkscape/inkscape.git" }, "target": { "id": 3472737, "name": "inkscape", "description": "Inkscape vector illustrator", "web_url": "https://gitlab.com/inkscape/inkscape", "avatar_url": "https://assets.gitlab-static.net/uploads/-/system/project/avatar/3472737/inkscape.png", "git_ssh_url": "git@gitlab.com:inkscape/inkscape.git", "git_http_url": "https://gitlab.com/inkscape/inkscape.git", "namespace": "Inkscape", "visibility_level": 20, "path_with_namespace": "inkscape/inkscape", "default_branch": "master", "ci_config_path": null, "homepage": "https://gitlab.com/inkscape/inkscape", "url": "git@gitlab.com:inkscape/inkscape.git", "ssh_url": "git@gitlab.com:inkscape/inkscape.git", "http_url": "https://gitlab.com/inkscape/inkscape.git" }, "last_commit": { "id": "73a0b7969ddcff550af4840e13bc07ed23144ab7", "message": "Add some handling fixes to selector classes\n", "timestamp": "2019-03-23T01:20:15Z", "url": "https://gitlab.com/inkscape/inkscape/commit/73a0b7969ddcff550af4840e13bc07ed23144ab7", "author": { "name": "Jabier Arraiza", "email": "jabier.arraiza@marker.es" } }, "work_in_progress": false, "total_time_spent": 0, "human_total_time_spent": null, "human_time_estimate": null, "action": "update" }, "labels": [ { "id": 3746188, "title": "ui", "color": "#428BCA", "project_id": 3472737, "created_at": "2018-03-28 15:08:40 UTC", "updated_at": "2018-03-28 15:08:40 UTC", "template": false, "description": "", "type": "ProjectLabel", "group_id": null } ], "changes": { "labels": { "previous": [ ], "current": [ { "id": 3746188, "title": "ui", "color": "#428BCA", "project_id": 3472737, "created_at": "2018-03-28 15:08:40 UTC", "updated_at": "2018-03-28 15:08:40 UTC", "template": false, "description": "", "type": "ProjectLabel", "group_id": null } ] } }, "repository": { "name": "inkscape", "url": "git@gitlab.com:inkscape/inkscape.git", "description": "Inkscape vector illustrator", "homepage": "https://gitlab.com/inkscape/inkscape" }, "assignee": { "name": "Tavmjong Bah", "username": "Tavmjong", "avatar_url": "https://secure.gravatar.com/avatar/faf7c5b7f2c3eb1a151d0b4f73345397?s=80&d=identicon" } } ```

I've obvserved that as well just now.

@Ede123 Did you find any workaround?

appveyor / ci