search

appveyor / ci

AppVeyor community support repository
https://www.appveyor.com
344 stars 64 forks source link

GH keeps using Appveyor after Webhook was deleted from GH repo #3845

Open dkhokhlov opened 1 year ago

dkhokhlov commented 1 year ago

GH keeps using Appveyor after Webhook was deleted from GH repo

https://github.com/logdna/logdna-agent-v2/pull/422

FeodorFitsner commented 1 year ago

AppVeyor is authorized as GitHub App. Uninstall "AppVeyor" GitHub app from logdna org and it will do the trick.

dkhokhlov commented 1 year ago

Uninstall and Install? We do use it.

FeodorFitsner commented 1 year ago

I'm sorry if I didn't catch the problem. Do you want to remove just this repo from AppVeyor CI, but leave it enabled for the rest of org?

dkhokhlov commented 1 year ago

Per "Uninstall "AppVeyor" GitHub app from logdna org and it will do the trick." we removed AV App from GH. this issue got resolved. BUT after adding AV back to GH - Ci checks are not working, GH does not show them. AV Webhook is defined and gets posted to AV w/o errors.

Repo: logdna/logdna-agent-v2 PR example: https://github.com/logdna/logdna-agent-v2/pull/422

How to make GH to use AV for CI checks back again?

FeodorFitsner commented 1 year ago

What AppVeyor account are you configuring it on?

dkhokhlov commented 1 year ago

AV account used for webhooks "dkhokhlov". GH login. this account authorized GH access before the reported issue was created. Another GH/AV account "gjanco" was used to delete AV App in GH and authorize it back.

FeodorFitsner commented 1 year ago

AppVeyor account must be authorized to access GitHub org even "AppVeyor" GitHub app is installed on GitHub. Login to AppVeyor, go to "New project" page and perform "Import existing installations". You should see your repo in the list. Repo-specific Webhook on GitHub is not required as GitHub App uses a centralized webhook.

dkhokhlov commented 1 year ago

I see one push triggers two AV builds:

@appveyor continuous-integration/appveyor/branch Pending — Waiting for AppVeyor build to complete

@appveyor continuous-integration/appveyor/pr Pending — Waiting for AppVeyor build to complete

How to make change that to build only once per push?

FeodorFitsner commented 1 year ago

Two ways to fix that:

1) Disable one of the options on "General" tab of project settings in AppVeyor:

Do not build on "Push" events Do not build on "Pull request" events

2) Add this to appveyor.yml:

skip_branch_with_pr: true
dkhokhlov commented 1 year ago

Strange, I enabled "Do not build on "Push" events" and did new push to pr but still see two checks scheduled on AV: image

FeodorFitsner commented 1 year ago

Could you drop a link to that commit/PR/build?

dkhokhlov commented 1 year ago

https://github.com/logdna/logdna-agent-v2/pull/422