Closed jeff-winn closed 5 years ago
What if we re-target the project to .NET Core 3.0 and try publishing it as a single self-contained executable? It's quite inconvenient that the tool requires the presence of .NET Core runtime on the machine.
You could very well choose to do so, I did a quick regression test targeting this for netcoreapp3.0 and it was able to decrypt the files using your existing deployed version along with encrypting and decrypting new files (using this version + .NET Core 3.0). So it should be fine if you wish to modify the target runtime in a separate change.
Just out of curiosity, are there plans to merge this or should I close the request?
Sorry about the delay with reviewing this PR! We've been busy with releasing some new stuff here. I'm going to finish with the PR this week.
@FeodorFitsner Will you give us a heads up when this is live? Or is it live already?
It should be live already, but it's fully backward compatible and shouldn't break existing builds. That's the trick.
I’m pretty sure your website documentation indicates to use the install.ps1 which is currently pointed at your 1.0.0 version. Which I didn’t update that, I wouldn’t have had access to create the release.
Correct. Release artifact was just updated with a newer version.
This pull request is to correct issue #2 wherein the salt used is static rather than a randomized value.
About the change... I had to do a bit of restructuring on the code to support what needed to be done, so there will be quite a few new files added, and quite a bit of the logic that was within Main has been lifted out to other classes. Hopefully this will make the tool easier to maintain and make changes to in the future.
A couple things:
If you have any questions, please feel free to ask!