search

appwrite / awesome-appwrite

Carefully curated list of awesome Appwrite resources 💪
https://appwrite.io
942 stars 282 forks source link

Almost Instagram Submission - Flutter + Appwrite #430

Closed letsintegreat closed 1 year ago

letsintegreat commented 1 year ago

What does this PR do?

I have added a demo project with flutter and appwrite - Almost Instagram.

Test Plan

Find the installation instructions in the README.md file of the linked repo.

Related PRs and Issues

This PR was made under this issue: https://github.com/appwrite/appwrite/issues/4286

Have you read the Contributing Guidelines on issues?

Yes.

stnguyen90 commented 1 year ago

@letsintegreat Thanks for the PR! 🤯 Please give us some time to review it.

gewenyu99 commented 1 year ago

Yeah @letsintegreat This is an amazing PR. Would love @lohanidamodar to take a look here, too.

I looked through the code base quickly. I might point out that it looks like you're initializing the Appwrite SDK/ Client class multiple times in different places in your code. I think this might be an issue because it's really meant to be initialized once and to have only one instance. (correct me if I'm wrong @stnguyen90)

Check the implementation here: https://github.com/appwrite/demo-almost-netflix-for-flutter (it might be a bit old)

letsintegreat commented 1 year ago

@gewenyu99 Thanks for suggesting the changes! I have fixed the usage of Client in this commit - https://github.com/letsintegreat/Almost-Instagram/commit/94d627f2628e04ec088a944f28cb3230803e734d

Now it is initialized only once. Kindly review now, thanks!

gewenyu99 commented 1 year ago

@gewenyu99 Thanks for suggesting the changes! I have fixed the usage of Client in this commit - letsintegreat/Almost-Instagram@94d627f

Now it is initialized only once. Kindly review now, thanks!

Nice! I'll give this a whirl later this week. Do you mind renaming the PR to reflect what you're submitting (i.e. Almost Instagram Submission).

More of our engineers will likely view this PR with a better title ;) I keep thinking this is a spam post where someone added a period to our readme file.

Again, thanks for the submission!

letsintegreat commented 1 year ago

@gewenyu99 Oops, I forgot to change the PR name, my bad! Thanks a lot for pointing it out.

gewenyu99 commented 1 year ago

Let me help you out by requesting reviews from our Flutter experts in case they didn't see this yet :)

letsintegreat commented 1 year ago

@gewenyu99 Thanks for bumping this PR up! Though I think you guys are getting a lot of PRs, and I understand if you can't review them right away.

letsintegreat commented 1 year ago

@stnguyen90 Hey! Thanks for reviewing the PR. I have addressed all of the three points in this commit. I have used Appwrite CLI to generate an appwrite.json file. And the README.md file now contains the entire setup process using Appwrite CLI.

Regarding bucket and collection permissions, they are now handled while creating the bucket and the collection. And I have also added instructions to register the client.

Please, review the PR again and LMK if there's something else that needs to be changed.

christyjacob4 commented 1 year ago

THANK YOU! All changes merged 🥳

Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord.  

You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub.

You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile.

Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :)