search

appwrite / demos-for-react

Demos and tutorials for getting started with Appwrite + React JS
https://appwrite.io
MIT License
92 stars 39 forks source link

Simple image cropping examples and tutorial in React #4

Closed spiritbroski closed 2 years ago

spiritbroski commented 4 years ago

This PR is regarding the issue #546.

Work done,

Simple image cropping examples and tutorial in React

christyjacob4 commented 4 years ago

Sorry for the delay. Reviewing it now

spiritbroski commented 4 years ago

no problem christy take your time

christyjacob4 commented 4 years ago

Very well written @spiritbro1 I would suggest you also run a linter to format all the code and push one more commit and then we're good to go

spiritbroski commented 4 years ago

@christyjacob4 how bout this one? https://github.com/appwrite/demos-for-react/pull/4#discussion_r502900032

christyjacob4 commented 4 years ago

@christyjacob4 how bout this one? #4 (comment)

Yea I understood now. I have left a reply

christyjacob4 commented 4 years ago

@spiritbro1 I would suggest you also run a linter to format all the code and push one more commit and then we're good to go

spiritbroski commented 4 years ago

@christyjacob4 linter done please check again

christyjacob4 commented 4 years ago

Great Job! 🥳

spiritbroski commented 4 years ago

thanks

On Sun, Oct 11, 2020, 10:35 PM Christy Jacob notifications@github.com wrote:

Great Job! 🥳

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/appwrite/demos-for-react/pull/4#issuecomment-706722809, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5B4AN4KSBDWM4WWKWE3YLSKHGEHANCNFSM4R4P6VCA .

christyjacob4 commented 4 years ago

Hey @eldadfux feel free to merge it. Looks good from my side