Code overhaul - Githubissues

appwrite / php-clamav

ClamAV network and pipe client for PHP

https://github.com/appwrite

MIT License

65 stars 30 forks source link

Closed SoftCreatR closed 4 years ago

SoftCreatR commented 4 years ago

Change fully-qualified function calls to namespaced function calls for simplicity. However, the performance gain is so little, that they could be completely removed.
Declare visibility for constants
Add return type hints
Perform small code optimizations
Re-Format files
Add missing dependency "ext-sockets" to composer.json
Update test namespace

eldadfux commented 4 years ago

Hey @SoftCreatR, why did you close the PR? changes actually looked pretty good.

SoftCreatR commented 4 years ago

Hey,

it's just, that I found some more optimization potential. I'll create a new PR, when done :)

eldadfux commented 4 years ago

👌🏻