Bug(cli): code.tar.gz file remains after error occurs

appwrite / sdk-for-cli

[READ-ONLY] Official Appwrite CLI >_

BSD 3-Clause "New" or "Revised" License

85 stars 29 forks source link

Bug(cli): code.tar.gz file remains after error occurs #99

Closed Vaibhav91one closed 1 month ago

Vaibhav91one commented 8 months ago

What does this PR do?

This PR mainly implements a Try catch and finally block to the functionCreateDeployment.
As if anything happens in between the finally block will always execute and will remove the remaining file.

Test Plan

N/A

Related PRs and Issues

https://github.com/appwrite/sdk-for-cli/issues/28

Have you read the Contributing Guidelines on issues?

Yes

Vaibhav91one commented 8 months ago

Hey, could you please clean up the commit and remove all the unnecessary white space type changes so we can find what changed more easily?

Sure.

stnguyen90 commented 8 months ago

I'm going to add the hacktoberfest-accepted label just so you get credit, but we'll probably close this PR since we need the change in the SDK generator repo.

gewenyu99 commented 2 months ago

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

stnguyen90 commented 1 month ago

closing as change needs to be done in sdk-generator repo.