search

appwrite / sdk-for-dart

[READ-ONLY] Official Appwrite Dart SDK 💙
https://appwrite.io
BSD 3-Clause "New" or "Revised" License
113 stars 17 forks source link

Allow to set chunkSize on createFile #36

Closed sgruhier closed 1 year ago

sgruhier commented 1 year ago

What does this PR do?

It’s an optional argument. It keeps default behaviour without any breaking changes.

Test Plan

Related PRs and Issues

None

Have you read the Contributing Guidelines on issues?

Yes

stnguyen90 commented 1 year ago

@sgruhier, thanks for opening this PR! 🙏🏼 Unfortunately, this is a read-only repo as the code is generated by our SDK Generator, and changes made only here would be wiped in the next release.

I would suggest creating an issue in the SDK Generator repo before submitting any PR for this. We prefer to keep our SDKs consistent so the team would need to agree on this change first and then we can roll out the change to all SDKs.

sgruhier commented 1 year ago

Thanks, I'll try to work with SDK Generator and make a pull request on it.

sgruhier commented 1 year ago

quick question. I did modification in SDK Generator repo. I generated dart files, but I do I test it?