search

appwrite / sdk-for-python

[READ-ONLY] Official Appwrite Python SDK 🐍
https://appwrite.io
BSD 3-Clause "New" or "Revised" License
226 stars 57 forks source link

🚀[FEATURE] : Properly implementing `getters` and `setters` for `client` #53

Closed hemangjoshi37a closed 1 year ago

hemangjoshi37a commented 1 year ago

This commit rightfully implements getters and setters for client

hemangjoshi37a commented 1 year ago

here mentioning #52 to get it resolved by this PR.

stnguyen90 commented 1 year ago

Thanks for creating this PR, but unfortunately, this is a read-only repo as the code is generated by our SDK Generator, and changes made only here would be wiped in the next release.

In addition, we want our SDKs to be consistent and be used like client.set_endpoint() so I'm not sure if we'll be incorporating this change.

hemangjoshi37a commented 1 year ago

@stnguyen90 That's why I see appwrite is not growing as other great databases because people like you are making terrible decisions. And infact the function client.set_endpoint() not even successfully setting the endpoint. so it is futile generating this repo from other. I dont think this is going to make a great experience using appwrite.