appwrite / sdk-for-web

[READ-ONLY] Official Appwrite Web SDK ๐Ÿงก
https://appwrite.io
BSD 3-Clause "New" or "Revised" License
271 stars 58 forks source link

๐Ÿš€ Enhancement: Custom type for OAuth2Provider instead of string #51

Closed probablyArth closed 1 year ago

probablyArth commented 1 year ago

๐Ÿ”– Feature description

image Custom type for OAuth2Provider instead of string like the one used here in appwrite-react https://github.com/sanny-io/react-appwrite/blob/main/src/account/types.ts

export type OAuth2Provider =
  | 'amazon'
  | 'apple'
  | 'auth0'
  | 'authentik'
  | 'autodesk'
  | 'bitbucket'
  | 'bitly'
  | 'box'
  | 'dailymotion'
  | 'discord'
  | 'disqus'
  | 'dropbox'
  | 'etsy'
  | 'facebook'
  | 'github'
  | 'gitlab'
  | 'google'
  | 'linkedin'
  | 'microsoft'
  | 'notion'
  | 'okta'
  | 'paypal'
  | 'paypalSandbox'
  | 'podio'
  | 'salesforce'
  | 'slack'
  | 'spotify'
  | 'stripe'
  | 'tradeshift'
  | 'tradeshiftBox'
  | 'twitch'
  | 'wordpress'
  | 'yahoo'
  | 'yammer'
  | 'yandex'
  | 'zoom'

๐ŸŽค Pitch

It can provide better developer experience.

๐Ÿ‘€ Have you spent some time to check if this issue has been raised before?

๐Ÿข Have you read the Code of Conduct?

joeyouss commented 1 year ago

Hi, thank you for the suggestion. This might be a bit difficult since we use the SDK generator for everything. However, your idea is appreciated and I will keep this issue open for now in case there are others from the community interested in discussing this.

stnguyen90 commented 1 year ago

@probablyArth this looks like a duplicate of https://github.com/appwrite/appwrite/issues/426. Can we close this and you can ๐Ÿ‘ the other issue?