appwrite / sdk-generator

Generating SDKs for multiple programming languages and platforms ⚙️
https://appwrite.io
MIT License
274 stars 173 forks source link

Fix: container start commands #1008

Closed Meldiron closed 2 weeks ago

Meldiron commented 2 weeks ago

What does this PR do?

In Python, we switched from Flask to asynciohttp library. With that, start command changed. CLI has start-command hard-coded, so we need to update it.

What I did instead is used helper bash script. This resolves the problem, and also ensures it doesn't happen in future. Those start helpers are what Open Runtimes tests use, so they are always 100% reliable.

I only manually tested everything working properly with Python and Node, but start helper is used for all runtime tests in Open Runtimes, so it gives me confidence it's not breaking anything currently working fine.

Fixes https://github.com/appwrite/appwrite/issues/8902

Test Plan

Before: CleanShot 2024-11-04 at 15 26 44@2x

After:

CleanShot 2024-11-04 at 15 29 04@2x

CleanShot 2024-11-04 at 15 29 30@2x

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Yes