🚀 Feature: Unit Tests

stnguyen90 commented 1 year ago

💭 Description

Add unit tests for each SDK

For reference on how to do this, refer to the Flutter/Dart templates: https://github.com/appwrite/sdk-generator/pull/673

[ ] android
[x] cli - not needed
[x] dart - completed as part of https://github.com/appwrite/sdk-generator/pull/673
[ ] deno
[ ] dotnet
[x] https://github.com/appwrite/sdk-for-flutter/issues/90 - completed as part of https://github.com/appwrite/sdk-generator/pull/673
[x] go - not ready
[x] graphql/docs - not needed
[ ] kotlin
[ ] node
[ ] php
[ ] python
[x] rest/docs - not needed
[ ] ruby
[ ] swift
[ ] web - ⌛ @tewarig

👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

tewarig commented 1 year ago

can i work on this ? would love to add test for web

lohanidamodar commented 1 year ago

@tewarig sure you can get started.

prathamesh3707 commented 1 year ago

i would like to work

leonyangela commented 1 year ago

Hi @Haimantika, can I work on node?? Thank you

Haimantika commented 1 year ago

i would like to work

Hi @prathamesh3707 have assigned the issue to you! Thank you for showing interest in contributing to Appwrite! Happy Hacktoberfest 🎃

Notes:

Please update us with your progress every 3 days, so that we know that you are working on it. Join us on Discord - https://appwrite.io/discord to chat about Hacktoberfest and Appwrite!

Haimantika commented 1 year ago

Hi @Haimantika, can I work on node?? Thank you

Hi, we are assigning issues on first-come first-serve basis. If @prathamesh3707 drops/is unresponsive, will assign it to you.

Haimantika commented 1 year ago

Hi @prathamesh3707 any update? This issue will soon be reassigned to the next person due to inactivity

prathamesh3707 commented 1 year ago

sorry, i saw it just now. Thanks for assigning it to me! I am working on it

Haimantika commented 1 year ago

sorry, i saw it just now. Thanks for assigning it to me! I am working on it

Hi, let us know in Discord if you have any questions :)

prathamesh3707 commented 1 year ago

Ya sure , I need a little help in getting started , I'll ask there. Is there any deadline for this?

mvarendorff commented 1 year ago

Heyyo! I would like to pick this up if possible. Let me know and I'll get started soon :)

airwakz commented 1 year ago

@Haimantika can i work on this

ujju200 commented 1 year ago

Can I work on this issue?

Haimantika commented 1 year ago

@leonyangela you are up next, would you like to work on it?

stnguyen90 commented 1 year ago

@leonyangela, the assignee would need to work on all the languages. Would you still like to work on this?

leonyangela commented 1 year ago

Hi @stnguyen90 @Haimantika thanks for mentioning me, I’m not sure if I can do it for all languages, you can assign it to the next person. Thanks

Haimantika commented 1 year ago

Heyyo! I would like to pick this up if possible. Let me know and I'll get started soon :)

Hi, you are up next, would you like to work on it?

mvarendorff commented 1 year ago

@Haimantika yes, I'd love to!

mvarendorff commented 1 year ago

Alrighties, I can give a quick update already!

I have started working on Kotlin / Android test and what I am relatively sure about is that I won't finish all languages and frameworks by the end of the month; they are just too many and I am not familiar with unit testing or even the language at all in them (never written any Ruby or Swift before for example). On top of that, I might even have to tweak some stuff here or there; the Android SDK for example is not really fit for (generated) unit testing because it relies on generics to return stuff which is not really nicely mockable. The Dart / Flutter SDK on the other hand uses a helper Response class which is handled by each Service internally which is something I am likely to copy over to the Kotlin one.

Since I am not sure how many of such bumps I am going to encounter, I just wanted to let you know that it's probably not going to be done by October 31st. I will put up a draft PR as soon as I have one of the checkboxes ticked though and will update as often as I can!

mvarendorff commented 1 year ago

3 day update: Kotlin and Android now share the same testsuite and a bit of the generated SDK's code (where it was easily doable). I don't know if it makes more sense to have individual PRs per SDK (genuinely orga-wise, not because I am greedy for PRs)?

mvarendorff commented 1 year ago

Next 3(-ish) day update! I am working fulltime next to this so I haven't been able to continue work on this in the last couple days, however plan for this weekend is tackling deno (and probably in extension node).

Question @stnguyen90 : Would you rather have separate PRs per language / framework (or group of them in case of android/kotlin) or everything in one?

mvarendorff commented 1 year ago

Heyyo, quick update: I will hold off on working on the remaining ones (ruby, swift and web(?)) for now since all changes made to the SDK (like the Query.between serialization) require quite some work updating all the active branches. So for the time being my last goal is fixing the pipeline for the Android / Kotlin PR and then stay quiet for a while.

appwrite / sdk-generator