Remove force unwrapping of incoming url parameters - Githubissues

appwrite / sdk-generator

Generating SDKs for multiple programming languages and platforms ⚙️

https://appwrite.io

MIT License

258 stars 160 forks source link

Remove force unwrapping of incoming url parameters #887

Open MarkPerkins opened 2 weeks ago

MarkPerkins commented 2 weeks ago

What does this PR do?

Avoid unnecessary crashes due to unrelated incoming URLs by:

guard against existence of URL components.
guard against query parameters
validate required cookies *bonus: discard result from user defaults synchronization.

Test Plan

Didn't see any unit test files, otherwise i'd add code coverage for them. Happy to do it if there is a testing scheme!

Create sample project with appwrite sdk
establish universal links
apply .registerOAuthHandler() to root view.
start firing deeplinks, which will crash on open.

Related PRs and Issues

Discord https://discord.com/channels/564160730845151244/1252726652044050572

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

Most of it. Followed PR naming, and added a issue on github.