appwrite / sdk-generator

Generating SDKs for multiple programming languages and platforms ⚙️
https://appwrite.io
MIT License
272 stars 168 forks source link

Fix variable names and logging in web and react-native docs templates #8328 #890

Closed kunalArya1 closed 1 month ago

kunalArya1 commented 3 months ago

Title: Fix Console Logging in Storage Client Example Templates

Description:

This PR addresses an issue in the example templates for the Appwrite documentation where the console logging of API responses was incorrectly referencing the response variable instead of the result variable. This discrepancy could potentially confuse users following the examples.

Changes Made:

Updated the console logging in the example templates for both the web and React Native clients to use the result variable consistently.

Context:

The original templates incorrectly used response in the console.log statement, which does not align with the variable naming conventions in the example code provided. By changing this to result, we ensure clarity and accuracy in the displayed examples.

Contributor Note:

This change aligns with the conventions observed throughout the documentation examples and improves the usability for developers integrating the Appwrite storage client in their applications.

References:

Fixes: https://github.com/appwrite/appwrite/issues/8328

Issue Link

This PR is ready for review. Your feedback is appreciated!

choir27 commented 1 month ago

After pulling your forked branch and generating the examples, I was able to confirm that your branch does generate the correct logging for web and react-native docs

Screenshot 2024-08-05 094302