Fixed file upload for .NET SDK

jtrcarlos commented 2 months ago

What does this PR do?

This PR includes fixes to the 'CreateFile' flow while using the .NET SDK which was not working. This changes were applied and tested directly to the SDK and then replicated to this template.

What was done:

ignored parameters with no value, which was causing a null object reference
fixed the logic regarding the GET method that checks for an already existing file with the same 'fileId'
fixed a malformed string (path for the GET method mentioned above)
fixed a wrong re-assignment of the 'parameters' variable (used in the GET method mentioned above)

Test Plan

This changes were tested manually by using a locally fixed version of the SDK, using both self-hosted and cloud endpoints. From what I found, if this is to be tested, it is using PHP, which I don't know.

Files used to test:

some .pdf (various sizes)
some .png (various sizes)

Related PRs and Issues

Issue #963

Have you read the Contributing Guidelines on issues?

Yes.

jtrcarlos commented 2 months ago

Issue #963 mentions removing "unique()" check that is missing from this PR.

dev-p26 commented 2 months ago

Any plan for when this fix is going to be released?

stnguyen90 commented 1 month ago

@jtrcarlos, thanks for creating this PR! 🙏🏼 Unfortunately, this isn't the approach we want to take as it doesn't match the other SDKs. We'll take it from here.

Also, in the future, please make sure you comment on the issue and ask to be assigned before submitting a PR to avoid wasted work.

appwrite / sdk-generator