Invalid image URL produces invalid image without a warning / error

apricote / hcloud-upload-image

Quickly upload any raw disk images into your Hetzner Cloud projects!

MIT License

21 stars 2 forks source link

Invalid image URL produces invalid image without a warning / error #33

Closed P4sca1 closed 4 months ago

P4sca1 commented 5 months ago

Thank you for this great tool! I noticed a small issue. When you provide a URL that is invalid, such as https://stable.release.flatcar-linux.net/amd64-usr/current/flatcar_production_hetzner_image.bin.bz2 (which returns a HTTP 404 response), the image still gets created without warnings or errors. Ideally, when downloading the image fails, the process should be interrupted and an error should be returned.

apricote commented 4 months ago

Fixed in 0.3.0. Thanks for the report :)