apriha / snps

tools for reading, writing, merging, and remapping SNPs
BSD 3-Clause "New" or "Revised" License
100 stars 19 forks source link

Add binary output buffer support #139

Closed insolite closed 3 years ago

insolite commented 3 years ago

Otherwise raises:

TypeError: a bytes-like object is required, not 'str'

for provided existing byte buffers.

codecov[bot] commented 3 years ago

Codecov Report

Merging #139 (ccffdb8) into develop (326391b) will decrease coverage by 1.48%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #139      +/-   ##
===========================================
- Coverage    93.43%   91.94%   -1.49%     
===========================================
  Files            8        8              
  Lines         1538     1540       +2     
  Branches       272      273       +1     
===========================================
- Hits          1437     1416      -21     
- Misses          54       77      +23     
  Partials        47       47              
Impacted Files Coverage Δ
src/snps/utils.py 89.87% <100.00%> (+0.26%) :arrow_up:
src/snps/ensembl.py 31.70% <0.00%> (-39.03%) :arrow_down:
src/snps/snps.py 94.70% <0.00%> (-1.10%) :arrow_down:
src/snps/resources.py 93.79% <0.00%> (-0.37%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 326391b...ccffdb8. Read the comment docs.

apriha commented 3 years ago

Note that this requires Python 3.7.1+ (see #140).

apriha commented 3 years ago

Thanks @insolite !