search

april-anh / pe

0 stars 0 forks source link

Missing return object in Logic UML diagram #17

Open april-anh opened 1 year ago

april-anh commented 1 year ago

I think UndoCommand should also return an object u to Parser, which will be passed to logic manger later.

image.png

nus-se-bot commented 1 year ago

Team's Response

According to module textbook, return values from constructor are optional.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The problem here is inconsistency. If return objects are omitted, they should be omitted in both function calls. It doesn't make sense as future developers may don't know where the object u comes from.

Hence, I think UndoCommand should also return an object u to Parser, which will be passed to logic manger later.