Closed NorbiPeti closed 2 years ago
I'm not sure what the right move is regarding moving the interfaces out of User and directly into Knight. This could mean additional maintenance work because of upstream changes in the future.
I agree, but they don't seem to be any large or complicated implementations, so I want to go in this direction. I'm removing the interfaces related to email login (CanResetPassword, MustVerifyEmail). The Authenticatable interface is talked about in the docs, I couldn't find anything for the Authorizable interface (though atm we aren't using any Laravel authorization AFAIK anyway). Personally, I don't think these implementations are going anywhere anytime soon but I could be wrong. In any case, we can deal with it when we next update Laravel lol.
Another option would be to convert my model superclass into a trait and an interface, though I don't really like that concept here. I feel like things like the primary key column name shouldn't be in a trait (though the permission/delflg stuff could be).