currently support same scope product, have un-implemented templates for different scope product, the cases written with TODO would need to be discussed (ideally implement them in the actual layers, and keep reparam=self_symb_cfg.reparam in get_product()
The cases without TODO are not urgent and could be ignored for now
Note that to simplify get_product() (avoid too many cases), calling self_layer.get_product() and other_layer.get_product() is different: e.g. if self_layer is input layer and other_layer is product layer, should always call other_layer.get_product(), self_layer.get_product() in this case would raise an error.
Discuss:
Could you check if id(cls) and id(CLASS_NAME) are different within the class methods? In my case the memory ids are different, so I only used issubclass(other_symb_cfg.layer_cls, cls). Might be a potential bug?
Discuss how the TODO would be implemented, which are the different cases for different-scope-product we discussed earlier
Added
get_product()currently support same scope product, have un-implemented templates for different scope product, the cases written with
TODOwould need to be discussed (ideally implement them in the actual layers, and keepreparam=self_symb_cfg.reparaminget_product()The cases without
TODOare not urgent and could be ignored for nowNote that to simplify
get_product()(avoid too many cases), callingself_layer.get_product()andother_layer.get_product()is different: e.g. ifself_layeris input layer andother_layeris product layer, should always callother_layer.get_product(),self_layer.get_product()in this case would raise an error.Discuss: Could you check if
id(cls)andid(CLASS_NAME)are different within the class methods? In my case the memory ids are different, so I only usedissubclass(other_symb_cfg.layer_cls, cls). Might be a potential bug?Discuss how the
TODOwould be implemented, which are the different cases for different-scope-product we discussed earlier