search

april-tools / cirkit

a python framework to build, learn and reason about probabilistic circuits and tensor networks
https://cirkit-docs.readthedocs.io/en/latest/
GNU General Public License v3.0
71 stars 1 forks source link

no checks for PR from forks #200

Open lkct opened 8 months ago

lkct commented 8 months ago

see https://github.com/april-tools/cirkit/issues/199#issuecomment-1942214246

lkct commented 8 months ago

this is sort of "expected", as forks should not be allowed to run workflows with secrets. https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request

yet we still need to reconfig the workflows to allow linting/testing on all PRs including from forks.

lkct commented 8 months ago

is it because it's awaiting approval? https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-private-forks I didn't remember seeing the awaiting message though I should be able to with write access. maybe also related to some repo/org settings? cc @arranger1044 (possibly https://github.com/april-tools/cirkit/labels/lo-pri? we first need to investigate how to make sure it's safe)

lkct commented 6 months ago

update: it must be first enabled by @arranger1044

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#enabling-workflows-for-forks-of-private-repositories