april-tools / cirkit

a python framework to build, learn and reason about probabilistic circuits and tensor networks
https://cirkit-docs.readthedocs.io/en/latest/
GNU General Public License v3.0
71 stars 1 forks source link

Need for an Overhaul of the symbolic interface #217

Closed lkct closed 4 months ago

lkct commented 7 months ago

The current implementation included too much entanglement between the symbolic interface and the concrete (tensorized) one, mainly through the SymbLayerCfg which intends for SymbolicLayer but includes info about Layer.

We need to redesign the interface to decouple the symbolic representation and the actual layers. The algorithmic part can be mainly kept but needs to be adapted to the new interface.

Further details are still to be discussed.