april-tools / cirkit

a python framework to build, learn and reason about probabilistic circuits and tensor networks
https://cirkit-docs.readthedocs.io/en/latest/
GNU General Public License v3.0
80 stars 4 forks source link

Refactor quad tree, quad graph, and about number of splits #227

Closed loreloc closed 3 months ago

loreloc commented 5 months ago

Currently, we have a quad tree function, which can possibly returns a quad graph. We should simplify things and match the nomenclature with the papers, i.e., by having a quad graph function.

gengala commented 5 months ago

Yes, it would be better if we had a function that by default returns a quad graph. This function takes as input two main args:

minor priority: imagine we are splitting a patch in two parts, this splitting may be performed vertically or horizontally.

arranger1044 commented 5 months ago

agreed