april-tools / cirkit

a python framework to build, learn and reason about probabilistic circuits and tensor networks
https://cirkit-docs.readthedocs.io/en/latest/
GNU General Public License v3.0
71 stars 1 forks source link

disable pylint warning on magic value comparison #24

Closed lkct closed 1 year ago

lkct commented 1 year ago

pylint R2004: magic-value-comparison


Reason to disable:

  1. Sometimes it's simply expected. The author of the code should guarantee the use of magic values is indeed intended.
  2. There are false negatives and this checker cannot guarantee the use of magic values is good even if enabled.

We disable this check for now until we find a good reason to re-enable it.