search

april-tools / cirkit

a python framework to build, learn and reason about probabilistic circuits and tensor networks
https://cirkit-docs.readthedocs.io/en/latest/
GNU General Public License v3.0
80 stars 4 forks source link

Allow using Gaussian input distributions in the ```image_data``` template method? #300

Closed isurulucky closed 1 week ago

isurulucky commented 1 month ago

Hi,

Cirkit already supports Gaussian input layer [1], however it's not accessible via the image_data template method. I experimented changing the validations in [2] to support Gaussian input distributions, and it seems to work - did not test extensively though. Is there a specific reason not to support Gaussian inputs distributions for images?

Thanks, Isuru.

[1]. https://github.com/april-tools/cirkit/blob/main/cirkit/symbolic/layers.py#L426 [2]. https://github.com/april-tools/cirkit/blob/main/cirkit/templates/circuit_templates/data.py

isurulucky commented 4 weeks ago

Added a draft PR which reflects the changes done: https://github.com/april-tools/cirkit/pull/301

loreloc commented 3 weeks ago

Hi Isuru, thanks a lot for reporting this. We plan to merge it for the next cirkit version.

isurulucky commented 1 week ago

Closing as the PR is merged.