search

april / certainly-something

WebExtension that shows certificate chains in an aesthetically pleasing manner.
https://addons.mozilla.org/en-US/firefox/addon/certainly-something/
Mozilla Public License 2.0
92 stars 20 forks source link

Support extension OID 1.3.6.1.4.1.311.21.1 #28

Closed sresthas closed 5 years ago

sresthas commented 5 years ago

@april I am an outreachy applicant, let me know if I could take this up

sresthas commented 5 years ago

Just like #19

april commented 5 years ago

Works for me, but please just pick one of these. :)

https://censys.io/certificates?q=parsed.unknown_extensions.id%3A+1.3.6.1.4.1.311.21.1

Paarmita commented 5 years ago

Hey, @april If nobody is working on it, can I take this one as my first contribution to certainly-something? I checked the code, do we need to add these OIDs in src/viewer/js/strings.js as other strings are mentioned?

sudhirsaharan commented 5 years ago

@twisted-sres @Paarmita Hey there , i am done with the setup of mozilla by following this link : https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Windows_Prerequisites Now for contributing on certainly something, how do i proceed with further setup process . Can you please tell , i am new to this .

april commented 5 years ago

@Paarmita Loooks like @twisted-sres took the other one, so go ahead.

asishkr123 commented 5 years ago

@april i am an outreachy applicant too , i need to contribute. so are you opening any new issues or will i have to contribute to the project myself. i know i am a bit late in the application process but any help will be appreciated.

Paarmita commented 5 years ago

@april It looks like there should be some more modification in the https://github.com/april/certainly-something/pull/29 PR as this is also an OID Certificate, so should I wait for the PR to be merged or create a new one?

devGeorgeOwi commented 5 years ago

@april I know i came in a bit late, but please is there any issues that i can take on? will be expecting more issues thanks

april commented 5 years ago

@Paarmita go ahead and create a new one, although I would generally recommend that you consider using the same data structure. :)

Paarmita commented 5 years ago

Thanks, 👍 Will create a new one then following instructions from already created PR.

noahwalugembe commented 5 years ago

Hi @april i have came in a bit late, and i cant find any bug to solve. Is it okay for you to help me out. I really want to contribute.

noahwalugembe commented 5 years ago

@april are you opening any new issues soon. i know i am a bit late in the application process but any help will be appreciated.

noahwalugembe commented 5 years ago

@april Can i also work on this issue Support extension OID 1.3.6.1.4.1.311.21.1 or i can wait for new issues

april commented 5 years ago

See also: https://github.com/PeculiarVentures/PKI.js/issues/223