search

april / certainly-something

WebExtension that shows certificate chains in an aesthetically pleasing manner.
https://addons.mozilla.org/en-US/firefox/addon/certainly-something/
Mozilla Public License 2.0
92 stars 20 forks source link

[WIP]: Support OID 1.3.6.1.4.1.311.21.7 #29

Closed sresthas closed 5 years ago

sresthas commented 5 years ago

Fixes #2 @april , please review, should I add Template major version and minor version also?

sresthas commented 5 years ago

Hey @april @glawrence, there is something that I am missing which is not displaying the templateMajorVersion on the certificate. Please look into this.

sresthas commented 5 years ago

Changed, @glawrence please review

sresthas commented 5 years ago

screenshot from 2019-03-02 07-01-15 Hey, it looks like this, I guess there is some problem in getting the data.

sresthas commented 5 years ago

screenshot from 2019-03-02 07-02-58 The web console looks like this

april commented 5 years ago

screenshot from 2019-03-02 07-01-15 Hey, it looks like this, I guess there is some problem in getting the data.

Given that "Microsoft Certificate Template" breaks across two lines, I would suggest creating a "Microsoft Cryptography" subsection (like Extensions) if Microsoft extensions exist, and then simply call the section "Certificate Template".

sresthas commented 5 years ago

The rest is fine? @april I think there is some problem with getting the major version

april commented 5 years ago

I made a comment about how critical is hoisted. Is it otherwise working? It sounded like it wasn't showing up for you.

sresthas commented 5 years ago

@april please review

glawrence commented 5 years ago

This PR is redundant now as #2 is fixed, I have tested this with the latest code on https://docs.microsoft.com and it works