Changed cursor for Panel tabs and text sections

april / certainly-something

WebExtension that shows certificate chains in an aesthetically pleasing manner.

https://addons.mozilla.org/en-US/firefox/addon/certainly-something/

Mozilla Public License 2.0

92 stars 20 forks source link

Changed cursor for Panel tabs and text sections #37

Closed Paarmita closed 5 years ago

Paarmita commented 5 years ago

Referenced issue- #33 and #34

glawrence commented 5 years ago

Personally I like the addition of the text cursor for where text can be selected, however I am less keen on the "hand" type pointer for the tabs, to me it implies something I can grab and move. I appreciate you have just taken what is on the issue but I think there must be a better way to highlight this. Ultimately it is up to @april though

glawrence commented 5 years ago

I have had a look at https://developer.mozilla.org/en-US/docs/Web/CSS/cursor#Values and to be fair you have used "pointer" not "grab", so actually I think this does work as is. Always helps to read docs before commenting! So whilst I quite like "cell" I think you have the right option. Over to @april now

april commented 5 years ago

Looks great, thanks!