april / certainly-something

WebExtension that shows certificate chains in an aesthetically pleasing manner.
https://addons.mozilla.org/en-US/firefox/addon/certainly-something/
Mozilla Public License 2.0
92 stars 20 forks source link

Tab bar has one vertical line on the left side and no line on right side #48

Closed ghost closed 5 years ago

ghost commented 5 years ago

Issue #47

glawrence commented 5 years ago

I have tested this and it works for me, it also works fine with #36 so I have tested this twice. I also like the change, so thank you Monika

april commented 5 years ago

The side effect of this is that the border between each tab is twice as think as the outer border. Could you collapse them?

april commented 5 years ago

Namely, if you look at the generated HTML, you have one tab separator on the outside and two separators between each of the other tabs. These should probably just be collapsing borders instead.

ghost commented 5 years ago

does collapsing border means you don't want border on both the outer sides ?

april commented 5 years ago

No, it means that the border between tabs is 2px wide and the border on the outside is 1px. Those inside borders should all be 1px, and honestly we probably shouldn't be using elements as dividers for this anyways. :)

ghost commented 5 years ago

ya right. Will change that :)

glawrence commented 5 years ago

I have tested and visually looks good now

april commented 5 years ago

This looks great except for the change to the handlebars file which should be unedited. :)

ghost commented 5 years ago

why not to remove <div class="panel-section-tabs-separator"></div>?

april commented 5 years ago

Err, right, my bad. That file can be changed, but there shouldn't be a change to the carriage returns at the end of the file. :)

april commented 5 years ago

(updated my comment above)

ghost commented 5 years ago

Oh yes I don't know why atom is adding that.

april commented 5 years ago

Now you have a different newline at the end of index.css. :)

april commented 5 years ago

Merged in 67c60309f9b7152ba8d77e66eb4b46572bce38af.