Closed ghost closed 5 years ago
I have tested this and it works for me, it also works fine with #36 so I have tested this twice. I also like the change, so thank you Monika
The side effect of this is that the border between each tab is twice as think as the outer border. Could you collapse them?
Namely, if you look at the generated HTML, you have one tab separator on the outside and two separators between each of the other tabs. These should probably just be collapsing borders instead.
does collapsing border means you don't want border on both the outer sides ?
No, it means that the border between tabs is 2px wide and the border on the outside is 1px. Those inside borders should all be 1px, and honestly we probably shouldn't be using elements as dividers for this anyways. :)
ya right. Will change that :)
I have tested and visually looks good now
This looks great except for the change to the handlebars file which should be unedited. :)
why not to remove <div class="panel-section-tabs-separator"></div>
?
Err, right, my bad. That file can be changed, but there shouldn't be a change to the carriage returns at the end of the file. :)
(updated my comment above)
Oh yes I don't know why atom is adding that.
Now you have a different newline at the end of index.css. :)
Merged in 67c60309f9b7152ba8d77e66eb4b46572bce38af.
Issue #47