search

april / decklist

The code behind decklist.org, which generates DCI Registration Sheets.
https://decklist.org/
MIT License
45 stars 20 forks source link

cut down on sideboard cards? #32

Closed tooomm closed 6 years ago

tooomm commented 6 years ago

Would it make sense to cut down the maximum entries in the sideboard to 15 different card names? As that is the maximum lines available and all further entries mess the judge box up, basically rendering all list unusable or unreadable: untitled

I think cutting down to 15 entries (no matter how much cards there are in total) keeps readability at least. Same could apply to the decklist and the number of available lines for card entries, too.

There should be an appropriate (and additional) warning for sure if not all cards make it to the list!

Nightfirecat commented 6 years ago

Should probably also be done for main deck; it has the same rendering issue after enough unique cards are entered.

tooomm commented 6 years ago

Are there enough lines for a commander deck by the way? I mean there are official tournaments as well, right? 😆

Nightfirecat commented 6 years ago

There are not, though I don't know what kind of registration sheets they use.

Fryyyyy commented 6 years ago

My fork currently supports spilling decklists over multiple pages, so feel free to steal the code (if it's still vaguely sync'ed with upstream)

Nightfirecat commented 6 years ago

This is fixed in #42.

tooomm commented 6 years ago

Should probably also be done for main deck; it has the same rendering issue after enough unique cards are entered.

Does your PR also cut down for the main deck? @Nightfirecat Or supports multiple pages as @Fryyyyy with his fork?

Nightfirecat commented 6 years ago

I believe I did go ahead and limit both maindeck and sideboard rendering to the number of available slots. I didn't write any logic for page looping.