search

aprilis / messenger

Unofficial Facebook Messenger app for elementary OS
GNU General Public License v3.0
90 stars 7 forks source link

Juno animation error #26

Closed Hedronmx closed 5 years ago

Hedronmx commented 5 years ago

I have installed this on juno and now animations are not working correctly on plank. When I click to open an app, the animation plays only at the start of the system, after a while animation gets faster and faster, until you can't see it anymore. If you killall plank then it resets to playing the animation for a while.

How can I restore plank so I can try and see if this app is the problem.

Thanks.

aprilis commented 5 years ago

You should be able to uninstall modified Plank version by entering messenger/plank directory and typing sudo make uninstall

Hedronmx commented 5 years ago

Alright so I uninstalled your modified version of plank and now the animation is back to normal. Any ideas on why??

aprilis commented 5 years ago

I guess Plank has received some updates in Juno but I'll have to check it

Hedronmx commented 5 years ago

Please do :D

aprilis commented 5 years ago

Hmm I've installed Juno and I can't see any issues with Plank behavior. But the good news is that Juno has the up-to-date version of Plank with some patches from me so it's possible now to integrate the app with the official version installed by default

Hedronmx commented 5 years ago

So should I reinstall plank and just build messenger, ignoring the plank steps? What should I do? It's weird because I have two machines with the same problem, no bounce animation when clicking on an app.

Hedronmx commented 5 years ago

I have reinstalled Juno and the animation error happens when I use your modified plank.

aprilis commented 5 years ago

I need to make some changes in code to make the app work with default Plank version but hopefully I'll finish it today

aprilis commented 5 years ago

OK, I've pushed changed to the new_api_plank brach. You can download it by typing

git checkout new_api_plank
git pull

Then build and install as always. If you have forked Plank version, you can run script/uninstall-plank.sh to remove it. Please let me know if everything works fine

Hedronmx commented 5 years ago

Cant pull on new_api_plank error- Please commit your changes or stash them before you merge.

aprilis commented 5 years ago

type git reset --hard and try again

Hedronmx commented 5 years ago

There's no autogen file in that branch.... I can't follow the read me instructions. Sorry for this, I'm not that advanced

aprilis commented 5 years ago

You don't need the autogen file anymore. Just skip the part about installing plank. You can see updated README here https://github.com/aprilis/messenger/tree/new_api_plank

Hedronmx commented 5 years ago

Works perfectly, feels snappier. Love it! Thank you