aprilwebster / googletransitdatafeed

Automatically exported from code.google.com/p/googletransitdatafeed
0 stars 0 forks source link

Bug in TooManyConsecutiveStopTimesWithSameTime check when stop times are undefined #310

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
There is a bug in the way the TooManyConsecutiveStopTimesWithSameTime check is 
currently implemented.  Specifically, if you have a series of stop times like:

TripA,StopA,7:00:00,7:00:00,1
TripA,StopB,,,2
TripA,StopC,,,3
TripA,StopD,,,4
TripA,StopE,,,5
TripA,StopF,,,6
TripA,StopG,7:30:00,7:30:00,7

The current validator will throw a warning that there are 6 consecutive stop 
times all with the same time (7:00) because the stop times with missing arrival 
and departure times (indicating they should be interpolated) are considered to 
have the same time as the first stop time.  This is a bug.

Of course, we still want to be able to catch situations like:

TripA,StopA,7:00:00,7:00:00,1
TripA,StopB,,,2
TripA,StopC,,,3
TripA,StopD,,,4
TripA,StopE,,,5
TripA,StopF,,,6
TripA,StopG,7:00:00,7:00:00,7

Where there is a sequence of stop times with no arrival or departure time set 
sandwiched between two stop times that DO have the same time.

Original issue reported on code.google.com by bdfer...@google.com on 1 Nov 2011 at 12:28

GoogleCodeExporter commented 8 years ago

Original comment by bdfer...@google.com on 1 Nov 2011 at 12:29

GoogleCodeExporter commented 8 years ago
Reviewed in http://codereview.appspot.com/5319066/ and committed in r1620.

Original comment by bdfer...@google.com on 1 Nov 2011 at 2:32