Remove compilation date from static library

aprovpn / ics-openvpn

Automatically exported from code.google.com/p/ics-openvpn

0 stars 0 forks source link

Remove compilation date from static library #321

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Hi!

 I'm trying to make a reproducible build of Bitmask Android, which borrows the vpn logic from your app, and for that I'd need to remove the code in jni/jniglue.c that embeds the date of compilation into the so file (https://code.google.com/p/ics-openvpn/source/browse/main/jni/jniglue.c#10)

 I think it's good for you too, not only for Bitmask, so I'm happy to discuss anything you want to to see if I should remove that line just for us, or not.

 Thanks

Original issue reported on code.google.com by parm...@sdf.org on 23 Jan 2015 at 4:10

GoogleCodeExporter commented 9 years ago

This issue was closed by revision 87309b35edd0.

Original comment by arne@rfc2549.org on 23 Jan 2015 at 5:29

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

Excuse me Arne, but I was interested on removing the "Loading openvpn native 
library $id$ compiled on..." line from libopvpnutil.so, and you didn't change 
that line.

Original comment by parm...@sdf.org on 27 Jan 2015 at 1:04

GoogleCodeExporter commented 9 years ago

[deleted comment]

GoogleCodeExporter commented 9 years ago

It doesn't, it's line 10 which worries me and your diff only affects
line 17.

I've tried adding the same two lines around line 10 and it works as I
expected, perhaps I'm missing something.

Original comment by parm...@sdf.org on 27 Jan 2015 at 1:28