The default value of partial in accepts() is False (the only correct default would be None, meaning let the schema do its job), and this argument is directly passed to schema.load(), overriding the schema instance's partial property and effectively breaking the passed in schema instance and the correct old behaviour.
Keeping this argument with a default value of None is acceptable, but I would avoid it because it would still violate several best practices and design principles, so I think it would be the best to reverse #81 or at least deprecate this argument.
Related issues: #80 and #62 (this should be the solution to partial loading).
Hi,
The default value of
partialinaccepts()isFalse(the only correct default would beNone, meaning let the schema do its job), and this argument is directly passed toschema.load(), overriding the schema instance'spartialproperty and effectively breaking the passed in schema instance and the correct old behaviour.Keeping this argument with a default value of
Noneis acceptable, but I would avoid it because it would still violate several best practices and design principles, so I think it would be the best to reverse #81 or at least deprecate this argument.Related issues: #80 and #62 (this should be the solution to partial loading).
Thanks and best regards, Peter