aprzn123 / TheThirdCan

A browser extension designed to improve https://twocansandstring.com
MIT License
7 stars 4 forks source link

feature: skip saved questions #20

Closed HumanoidSandvichDispenser closed 1 year ago

HumanoidSandvichDispenser commented 1 year ago

Resolves #18, which allows the user to skip saved questions whether they are active, inactive, or deleted.

aprzn123 commented 1 year ago

I'll take a closer look later when I have more time, but this looks good so far.

aprzn123 commented 1 year ago

Just gave it a test, what if you made the remove button smaller (maybe a square around an X) and put it to the left of the questions? Could probably do that with inline styling, shouldn't need to add a whole new CSS file. image Like this but with maybe a bit more spacing between the link and the button is what I'm thinking.

HumanoidSandvichDispenser commented 1 year ago

Sounds good. I will work on it later.

HumanoidSandvichDispenser commented 1 year ago

image

aprzn123 commented 1 year ago

Nice :)

Also, not sure if this is scope creep, but what if you added a "delete all" button? I think a lot of people would find that useful, and I think it's relevant to this PR.

HumanoidSandvichDispenser commented 1 year ago

I'm thinking of that, but I realize that it might not work because you could be rate limited. I currently do not know any way to skip multiple questions at once other than making multiple API calls.

aprzn123 commented 1 year ago

If there are potential rate limit issues, we can just keep this one as is and work that out later. You think this one's about ready, then?

HumanoidSandvichDispenser commented 1 year ago

Yeah, this is ready to merge.

aprzn123 commented 1 year ago

I'll take one more look in a bit before merging, but I think it's good!

aprzn123 commented 1 year ago

LGTM