aprzn123 / TheThirdCan

A browser extension designed to improve https://twocansandstring.com
MIT License
7 stars 4 forks source link

add hot keys for answer page #21

Closed leonn00albert closed 1 year ago

leonn00albert commented 1 year ago

I added hot keys for answer page

ctrl + enter -> answer s -> save backspace -> skip

leonn00albert commented 1 year ago

Heey

I made the required changes I think? (Sorry first time contributing )

https://twocansandstring.com/users/wdlndfx

roxwize commented 1 year ago

I feel like S and Backspace should be change to a keyboard combination so that it doesn't disrupt typing in the textbox.

aprzn123 commented 1 year ago

@thekifake That's already been updated to ctrl+s and ctrl+backspace, but I just suggested changing ctrl+backspace to ctrl+n

roxwize commented 1 year ago

Oh, okay. I didn't notice that.

leonn00albert commented 1 year ago

I have added a tooltip to show the the hotkey layout on hover

image

aprzn123 commented 1 year ago

The question mark symbol looks a little off-center on my end, it might be better to pull in an icon set like FontAwesome. Other than that and switching to a better hotkey than ctrl+m, it looks good enough to merge imo.

leonn00albert commented 1 year ago

I added font awesome icon instead (using cdn)

aprzn123 commented 1 year ago

Is there any opposition anyone here about switching the the "skip" key binding from ctrl+backspace to ctrl+m?

If there's not, then I'll ask you to go ahead with it, and then I can merge!

HumanoidSandvichDispenser commented 1 year ago

Not an issue for now, but we should also add hotkeys for the "skip for now button" soon

aprzn123 commented 1 year ago

That feels like we should work on it separate from this PR, can you put in an issue for it?

leonn00albert commented 1 year ago

ok i changed it

aprzn123 commented 1 year ago

You didn't update the tooltip

leonn00albert commented 1 year ago

My bad been a long day changed it

aprzn123 commented 1 year ago

Looks good, going to merge it!

Thanks for your contribution!