search

aps-8id-dys / bluesky

XPCS bluesky instrument configuration
Other
2 stars 0 forks source link

Damm ophyd device #24

Closed MDecarabas closed 2 months ago

MDecarabas commented 2 months ago
prjemian commented 2 months ago

In the original statement (above), I prefixed the close #22 with a -. Github makes this statement more descriptive by automatically adding the issue's title.

prjemian commented 2 months ago

There's a merge conflict in an __init__.py file.

MDecarabas commented 2 months ago

Ok, I will ask them when I see them today and relay the information back

prjemian commented 2 months ago

@qzhang234 @sureshnaps - Just a question of names here. There's an inconsistency in the names (.DESC) given to the EPICS motors for pitch & yaw. Why do the screens show "h" and "v"? Should we propagate this into the ophyd support? See my question above.

qzhang234 commented 2 months ago

@prjemian I'm with Eric at the beamline. Just to confirm, is the question on pitch and yaw related to the DAMM definition?

prjemian commented 2 months ago

Yes

sureshnaps commented 2 months ago

[Attachment.png] [Attachment_1.png] [Attachment_2.png] [Attachment_3.png] [Attachment_4.png]

damm is just a fixed aperture that can be scanned in X and Y (h and v)

slit with the exception of the 2 in 8ida are all standard 4-blade JJ slits, with added H,V translation underneath to move the whole slit which does not impact the slit database in anyway.

The RL-1 which is CRL-1 is the one that has x,y,pitch, yaw and 10 lens motors - this is separate than the above 2

Get Outlook for iOShttps://aka.ms/o0ukef

From: Pete R Jemian @.> Sent: Thursday, June 6, 2024 1:35:48 PM To: aps-8id-dys/bluesky @.> Cc: Narayanan, Suresh @.>; Mention @.> Subject: Re: [aps-8id-dys/bluesky] Damm ophyd device (PR #24)

Yes — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned. Message ID: aps-8id-dys/bluesky/pull/24/c2153159162@ github. com ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ZjQcmQRYFpfptBannerStart This Message Is From an External Sender This message came from outside your organization.

ZjQcmQRYFpfptBannerEnd

Yes

— Reply to this email directly, view it on GitHubhttps://urldefense.us/v3/__https://github.com/aps-8id-dys/bluesky/pull/24*issuecomment-2153159162__;Iw!!G_uCfscf7eWS!Zm8KeJ_zInFA0XTU7CPAQWf0kdZ3ck4CwBsQEzW5g5AjmAN-zPNc4grZuCH8EoCEqh-lOue5F4pxvxfNSpo9jQ9PMg$, or unsubscribehttps://urldefense.us/v3/__https://github.com/notifications/unsubscribe-auth/AAYSAQ23FSXKHD242ZVWFYLZGCTYJAVCNFSM6AAAAABI46VKT6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJTGE2TSMJWGI__;!!G_uCfscf7eWS!Zm8KeJ_zInFA0XTU7CPAQWf0kdZ3ck4CwBsQEzW5g5AjmAN-zPNc4grZuCH8EoCEqh-lOue5F4pxvxfNSprEpIctow$. You are receiving this because you were mentioned.Message ID: @.***>

prjemian commented 2 months ago

I did not get any attachments in the GitHub comments. Sent by email? Please post them to this PR.