search

aps-8id-dys / ipython-8idiuser

8-ID-I ipython configuration for bluesky (and other)
1 stars 1 forks source link

Rigaku `staging_mode.get` bug from pull request #253 #254

Closed qzhang234 closed 3 years ago

qzhang234 commented 3 years ago

@prjemian I approved the merge in #253 and pulled from master to local. Upon running Bluesky, I noticed that the mode value is set to be fast and cannot be changed by adrigaku.staging_setup_DM. Further inspection shows that the mode value is set to be fast by default in this line: https://github.com/aps-8id-dys/ipython-8idiuser/blob/fc17d6e442c354ea53202ff8184cc7a7c0a00e87/profile_bluesky/startup/instrument/devices/ad_rigaku_detector.py#L90

Is this line causing the bug? If so, could you show me how I should fix it? I would like to try to submit a pull request to resolve this too.

Thanks!

Terminal Output ``` In [2]: from instrument.devices.ad_rigaku_detector import adrigaku In [3]: adrigaku.staging_setup_DM(mode='slow') In [4]: adrigaku.staging_mode.get() Out[4]: 'fast' In [5]: ```
qzhang234 commented 3 years ago

The development of AD_Acquire has went past this issue. Closing the issue now.