search

aps-8id-dys / ipython-8idiuser

8-ID-I ipython configuration for bluesky (and other)
1 stars 1 forks source link

Rigaku fast/slow mode staging not working #270

Closed qzhang234 closed 3 years ago

qzhang234 commented 3 years ago

@prjemian I tried to stage Rigaku detector to acquire in fast mode, however the behavior (screenshot) is quite different from what we had in March and the parameters for the ZDT mode is not passing into the IOC.

Any suggestions?

image

qzhang234 commented 3 years ago

@prjemian It looks like in the current ad_rigaku_detector.py file, when fast mode is selected, it only updates adrigaku.stage_sigs which is a dictionary, however the values were never passed to the PVs. Assuming that we may need to switch between fast and slow mode after Bluesky started, where is a good place to define this function?

We may need to make similar implementations for Lambda detector as well since it can also have different acquisition modes

https://github.com/aps-8id-dys/ipython-8idiuser/blob/1198f3131cf971294bea254c1f298416c9fdbbdd/profile_bluesky/startup/instrument/devices/ad_rigaku_detector.py#L147-L156

qzhang234 commented 3 years ago

Also AD_Acquire currently set Rigaku mode to be fast by default. Should we add the option to switch between fast and slow mode?

https://github.com/aps-8id-dys/ipython-8idiuser/blob/1198f3131cf971294bea254c1f298416c9fdbbdd/profile_bluesky/startup/instrument/devices/ad_rigaku_detector.py#L66-L81

qzhang234 commented 3 years ago

Problem identified. The reason staging did not work is because self.cam.staging_mode is set to be fast , and the if block in the staging setup later checks for self.cam.staging_mode instead of the kwarg input.

The problem is now fixed and the fast/slow mode can be toggled in Bluesky. The syntax is attached in the screenshot.

Closing the issue now.

image