Closed ashmaroli closed 7 years ago
:white_flag: Down boy, down..!
:meat_on_bone:
@ashmaroli Go ahead and open this up again and we'll review. Houndbot is a bit crazy sometimes. Everything here looks fine to me, with the exception of the removal of the explicit return
statements.
@ashmaroli Looks good. We'll deploy a minor version bump of the gem sometime in the next couple weeks.
Thanks. Have a few questions to ask..
jekyll_config["jekyll_tidy"] && jekyll_config["jekyll_tidy"]["ignore_env"]
site.config
directly to Tidy.init
instead of site
and then compute further..
This is mostly a matter of style.
self.
in a module by extending to itsself
return
is not required if that is the last expression in a blockJekyll::Hooks.register
can be referred to as simplyHooks.register
if they're within the Jekyll module.Its all fine if you choose not to merge this in..